Rework debug into full syslog wrapper #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep debug_dbg macro for compatibility, to be removed after adapting each calling site.
Call log_debug_enable() to enable logging
Replace all debug_dbg() calls with LOG(), using an appropriate log level. Erase the debug_dbg() as nothing is relying on it anymore. The new LOG() macro does not depend on the configuration, so the configuration object (of type cfg_t) does not need to be passed around as parameter.
This is aligned with the "Module Wrtiers' Guide" of pam-linux. Enable mock_syslog for tests/expand in Autoconf, since tests/expand will now use syslog(3). Not needed on CMake.
LDVG
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
debug_file=option has been removed, and logging is only sent to syslog, we can make use of log levels.The
debugmodule is renamed aslogging, and thedbg_debugcall is replaced withLOG(Level, ...).The configuration (
cfg_tobject) is no longer necessary in a number of functions, since it was only required as argument for thedbg_debugcall.