Remove debug_file= #357
Merged
Remove debug_file= #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pam-u2f.so loses the ability to send debug info towards a file or stdout. It is still possible to log on stderr via syslog, e.g.: openlog(argv[0], LOG_PERROR, 0); Changelog: breaking
cfg_t::debug_file is no longer assigned in tests. Nothing else is referencing the field, so now we can remove it too. This commit introduces a mock syslog implementation that hijacks the logging on stderr. The intention is to avoid spamming the system log when the unit tests are compiled with Automake. The approach seems to be effective on all tested systems, but it is not clear if relies on a well defined behaviour, that will work on *all* systems. We accept the risk for now, since this is only affecting the tests, only for Automake, and since the most likely adverse outcome is syslog spamming. The CMake build, which will eventually replace Automake, is not affected: in such context the unit tests are linked against a dedicated build of the tested code, compiled with the PAM_U2F_TESTING macro defined.
Changelog: docs
Changelog: docs
LDVG
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing the
debug_file=option, both from the pam_u2f.so arguments and configuration.The module loses the ability to send debug info towards a file or stdout. It is still possible to log on stderr via syslog, e.g.
This is a breaking change, so it is targeting the
nextbranch instead ofmain, meaning that these change will flow into the first scheduled major bump.