Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README modifications #354

Merged
merged 5 commits into from
Mar 4, 2025
Merged

README modifications #354

merged 5 commits into from
Mar 4, 2025

Conversation

dacav
Copy link
Contributor

@dacav dacav commented Feb 27, 2025

No description provided.

@dacav dacav requested a review from LDVG February 27, 2025 16:16
@dacav dacav force-pushed the dacav/README-1 branch 2 times, most recently from 51cd085 to 30961d1 Compare February 28, 2025 14:50
@dacav dacav marked this pull request as draft March 4, 2025 08:22
@dacav dacav force-pushed the dacav/README-1 branch 2 times, most recently from cca956f to d510c6f Compare March 4, 2025 08:57
@dacav dacav marked this pull request as ready for review March 4, 2025 08:59
Copy link
Contributor

@LDVG LDVG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though the first commit message needs amending after the changes introduced by the first review cycle 😃

dacav added 5 commits March 4, 2025 11:23
Drop the `[source, console]` tags. Doing so produces the right results
on both Github and developers.yubico.com.

`apt install` instructions are broken on multiple lines, and package names
sorted alphabetically.
autoconf/automake/libtool are only needed if building from git, as the dist
tarball is not depending on autotools.

The reference to GNU Autotools has been moved under "Building from Git", since
this detail is interesting only for those who clone the project.
@dacav
Copy link
Contributor Author

dacav commented Mar 4, 2025

Looks good to me, though the first commit message needs amending after the changes introduced by the first review cycle 😃

Fixed the commit message. Nice catch.

@dacav dacav merged commit 3f20938 into main Mar 4, 2025
31 checks passed
@dacav dacav deleted the dacav/README-1 branch March 4, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants