Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web rtc options #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jacobcoro
Copy link

@jacobcoro jacobcoro commented Apr 15, 2023

Adds the ability to add web RTC options as noted in a todo in the code that is now removed.
It also adds the ability to add passwords to the web RTC room, as that is one of the options

@@ -0,0 +1,40 @@
/**
* @vitest-environment jsdom
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise it says it can't find WebSockets

@YousefED
Copy link
Owner

YousefED commented May 4, 2023

This is great! I think the only thing missing is to be able to actually pass the options to MatrixProvider, which in turn should pass it to initializeWebrtc on line 435. Would you mind adding this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants