427 add info button and tooltip #22009
Open
+250
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraja-pro
added
the
changelog: non-user-facing
Pull Request Test Coverage Report for Build 557765baca9041e958d9ce92ff2c01e25aef83d6Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
CR: ✅
|
pls78
requested changes
Feb 3, 2025
Co-authored-by: Paolo L. Scala <[email protected]>
Comment on lines
-5
to
-10
|
|
||
| --yst-display-tooltip: none; | ||
|
|
||
| &:hover, &:focus-within { | ||
| --yst-display-tooltip: inline-block; | ||
| } |
There was a problem hiding this comment.
This variable is used in the tooltip CSS:
| import Tooltip from "../../elements/tooltip"; | ||
| import { useToggleState } from "../../hooks"; | ||
|
|
||
| const GRACE_MRGIN = 10; |
There was a problem hiding this comment.
Suggested change
| const GRACE_MRGIN = 10; | |
| const GRACE_MARGIN = 10; |
| aria-describedby={ ariaDescribedby } | ||
| aria-disabled={ true } | ||
| onMouseEnter={ show } |
There was a problem hiding this comment.
Should this be onPointerEnter?
| @@ -38,12 +45,14 @@ Tooltip.propTypes = { | |||
| children: PropTypes.node, | |||
| className: PropTypes.string, | |||
| position: PropTypes.oneOf( Object.keys( positionClassNameMap ) ), | |||
| variant: PropTypes.oneOf( [ "dark", "light" ] ), | |||
There was a problem hiding this comment.
Suggested change
| variant: PropTypes.oneOf( [ "dark", "light" ] ), | |
| variant: PropTypes.oneOf( Object.keys( variantClassNameMap ) ), |
| document.removeEventListener( "pointermove", handleMouseMove ); | ||
| handleMouseMove.cancel(); | ||
| }; | ||
| }, [ show, hide, triggerRef, tooltipPosition, isVisible ] ); |
There was a problem hiding this comment.
I don't think triggerRef every changes. Do you mean triggerRef.current to verify the DOM node / memory address?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
info-dummy-data.patch.
UI Library - Tooltip container component
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes Add info button and tooltip