-
Notifications
You must be signed in to change notification settings - Fork 68
Added Mobile Radio #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enhanced
Are you sure you want to change the base?
Added Mobile Radio #173
Conversation
|
||
virtual void OnCall() override | ||
{ | ||
Stats::SetInt("MPPLY_XMASLIVERIES0", 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of these stats should probably be -1, and using 1 will only unlock 1 camouflage in the category
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you mean make this?
Stats::SetInt("MPPLY_XMASLIVERIES0", -1);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you mean make this?
Stats::SetInt("MPPLY_XMASLIVERIES0", -1);
yes
@@ -4,7 +4,7 @@ | |||
|
|||
namespace YimMenu::Features | |||
{ | |||
class SuperRun : public LoopedCommand | |||
class SlideRun : public LoopedCommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we renaming this?
} | ||
}; | ||
|
||
static mobile_radio _mobile_radio{"mobileradio", "MOBILE_RADIO", "Play GTA V Radio without vehicle Press Q the choose your Radio the hear"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command label isn't a translation string anymore
|
||
namespace YimMenu::Features | ||
{ | ||
class mobile_radio : public LoopedCommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MobileRadio
|
||
virtual void OnCall() override | ||
{ | ||
Stats::SetInt("MPPLY_XMASLIVERIES0", -1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but I'm not willing to accept this feature as it is now since I feel it isn't ready yet. Please remove it and all UI changes related to this, and maybe create a new PR later down the line with the bugs fixed
} | ||
}; | ||
|
||
static mobile_radio _mobile_radio{"mobileradio", "MOBILE_RADIO", "Play GTA V Radio without vehicle Press Q the choose your Radio the hear"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just say "Allows you to listen to any radio station on foot"
Mobile Radio has been added!
Created Recovery Section
Added Unlock New Chameleons Colors