Skip to content

Added Mobile Radio #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: enhanced
Choose a base branch
from
Open

Added Mobile Radio #173

wants to merge 12 commits into from

Conversation

CSY0N
Copy link
Contributor

@CSY0N CSY0N commented Apr 12, 2025

Mobile Radio has been added!

Created Recovery Section
Added Unlock New Chameleons Colors


virtual void OnCall() override
{
Stats::SetInt("MPPLY_XMASLIVERIES0", 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of these stats should probably be -1, and using 1 will only unlock 1 camouflage in the category

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you mean make this?

Stats::SetInt("MPPLY_XMASLIVERIES0", -1);

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you mean make this?

Stats::SetInt("MPPLY_XMASLIVERIES0", -1);

yes

@@ -4,7 +4,7 @@

namespace YimMenu::Features
{
class SuperRun : public LoopedCommand
class SlideRun : public LoopedCommand
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we renaming this?

}
};

static mobile_radio _mobile_radio{"mobileradio", "MOBILE_RADIO", "Play GTA V Radio without vehicle Press Q the choose your Radio the hear"};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command label isn't a translation string anymore


namespace YimMenu::Features
{
class mobile_radio : public LoopedCommand
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MobileRadio


virtual void OnCall() override
{
Stats::SetInt("MPPLY_XMASLIVERIES0", -1);
Copy link
Collaborator

@maybegreat48 maybegreat48 Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but I'm not willing to accept this feature as it is now since I feel it isn't ready yet. Please remove it and all UI changes related to this, and maybe create a new PR later down the line with the bugs fixed

}
};

static mobile_radio _mobile_radio{"mobileradio", "MOBILE_RADIO", "Play GTA V Radio without vehicle Press Q the choose your Radio the hear"};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just say "Allows you to listen to any radio station on foot"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants