Feature/outfit editor #140

BegaMetaZone · 2025-04-10T07:30:33Z

added outfit slot editing feature with the help of CoPilot , excuse my rusted skills I learned coding with pascal , UI integration might not be the best , again sry . I couldn't figure out why cmakelist didn't found the libs so I had to ..

Psifter · 2025-04-10T11:21:10Z

for cmake to find the lib* you just have to hit control s on the file

yigitboi07 · 2025-04-10T12:04:34Z

this should be a great feature if its implented correctly!

maybegreat48 · 2025-04-10T22:50:01Z

CMakeLists.txt

@@ -14,7 +14,11 @@ include(cmake/minhook.cmake)
 set(SRC_DIR "${PROJECT_SOURCE_DIR}/src")
 file(GLOB_RECURSE SRC_FILES
    "${SRC_DIR}/**.hpp"
-    "${SRC_DIR}/**.cpp"    
+    "${SRC_DIR}/game/backend/OutfitManager.hpp"


Please revert this

maybegreat48 · 2025-04-10T22:51:02Z

src/game/backend/OutfitManager.cpp

+
+#include "game/gta/Natives.hpp"
+
+namespace YimMenu


You don't need an outfit manager, just put all the necessary logic under OutfitEditor and delete this file

Or maybe add them to the Ped class

maybegreat48 · 2025-04-10T22:51:45Z

src/game/frontend/GUI.cpp

@@ -96,4 +97,77 @@ namespace YimMenu
 			ScriptMgr::Yield();
 		}
 	}
+
+	void GUI::ShowOutfitAndPropEditor()


You shouldn't add UI stuff to GUI.cpp. That's what the submenu files are for

maybegreat48 · 2025-04-10T22:52:05Z

src/game/frontend/GUI.cpp

+
+	void GUI::ShowOutfitAndPropEditor()
+	{
+		auto ped = PLAYER::PLAYER_PED_ID();


Use Self::GetPed instead

maybegreat48 · 2025-04-10T22:53:18Z

src/game/frontend/GUI.cpp

+		auto ped = PLAYER::PLAYER_PED_ID();
+		if (!ENTITY::DOES_ENTITY_EXIST(ped))
+		{
+			Notifications::Show("Error", "Player not found", NotificationType::Error);


Use ImGui::TextDisabled to tell the user this

maybegreat48 · 2025-04-10T22:54:09Z

src/game/frontend/GUI.cpp

+			return;
+		}
+
+		ImGui::Begin("Outfit and Prop Editor");


You don't need a separate window

maybegreat48 · 2025-04-10T22:55:08Z

src/game/frontend/submenus/OutfitEditor.cpp

+	OutfitEditor::OutfitEditor() :
+	    Submenu::Submenu("Outfit Editor")
+	{
+		// Create a shared_ptr for the category


Make sure all UI stuff goes here and not in a separate window. The seemingly AI-generated comment above this line isn't very helpful

maybegreat48 · 2025-04-10T22:57:25Z

src/game/frontend/submenus/OutfitEditor.cpp

+namespace YimMenu::Submenus
+{
+	OutfitEditor::OutfitEditor() :
+	    Submenu::Submenu("Outfit Editor")


Actually, on second thought, this shouldn't be a submenu at all. Add this as a new category under self (but still create a separate file)

maybegreat48 · 2025-04-10T22:58:24Z

src/game/frontend/GUI.cpp

+			const int maxDrawable = OutfitManager::GetMaxDrawable(i);
+			int maxTexture        = OutfitManager::GetMaxTexture(i, drawable);
+
+			const char* slotName = (i < 12) ? outfitSlotNames[i] : "Unknown";


Unnecessary check since i can never exceed 11

maybegreat48 · 2025-04-10T23:02:58Z

src/game/frontend/GUI.cpp

+			const char* propName = propNames[i];
+
+			// Precompute labels
+			std::string drawableLabel = std::string(propName) + " Drawable##" + std::to_string(i);


Slightly nitpicky but you can replace all your string concatenations with std::format and also get rid of the "cache" and "precompute" stuff because it still gets calculated every tick

last one didn't have the cache and it wasn't snappy , it had a delay without caching but alright I'll try to implement these changes .

Reorganized into a dedicated category under the Self menu (not a separate submenu). Some Error handling and more fixes .

xAzurrr · 2025-04-12T13:04:41Z

is there a way to implement a tattoo editor ?. i looked into but nothing seems to work,. also they dont overlap

BegaMetaZone · 2025-04-12T13:38:16Z

I was wondering that myself, have 2 check

Deadlineem · 2025-04-13T08:58:36Z

This is a great feature IF it is properly implemented. What I mean by this is, YimMenu V1 had an outfit editor, it was a bit buggy and not labeled correctly, also, it was stuck in one position on the screen (So you could not see your character with the menu opened) resulting in having to show/hide the menu for each outfit item you changed.

I changed this in YimMenu V1 (Chronix) so the outfit editor is movable/resizable and fixed all the mismatched labeling as well as added tabs (Clothing/Accessories) for a better user experience.

As far as the labeling went, the original outfit editor was, to my own guess, built in story mode, which made the clothing item labels "correct" in the menu, but for MP, they were wrong.

https://github.com/Deadlineem/Chronix/blob/main/src/views/self/view_outfit_editor.cpp

BegaMetaZone · 2025-04-13T12:42:28Z

Before moving it under self this had separate window and it was editable but now it's under self and follows top UI properties which is fine , also the labels can be edited but for me they are fine rn , I didn't want to force outfits so if game doesn't like ur selection ( invis body ) it will automatically fix it after couple of seconds , I added Outfit Preset Saving in my local branch plus tattoo editing but tattoo isn't working rn , does not draw . about the preset saving , since it wasn't persistent when I reloaded the game I didn't push it .

Deadlineem · 2025-04-13T15:39:08Z

Before moving it under self this had separate window and it was editable but now it's under self and follows top UI properties which is fine , also the labels can be edited but for me they are fine rn , I didn't want to force outfits so if game doesn't like ur selection ( invis body ) it will automatically fix it after couple of seconds , I added Outfit Preset Saving in my local branch plus tattoo editing but tattoo isn't working rn , does not draw . about the preset saving , since it wasn't persistent when I reloaded the game I didn't push it .

To make it persist you need to save the outfit files in .json like yimv1 does (saved_outfits folder) and then the persist outfit would apply on a loop from that ,json outfit.

I personally did not like having the editor in the main UI on YimV1 bc it was so bulky, but i think it'd be ok with this UI as it doesn't overlay over your character.

qwertyuiop11243 · 2025-04-14T03:18:42Z

Before moving it under self this had separate window and it was editable but now it's under self and follows top UI properties which is fine , also the labels can be edited but for me they are fine rn , I didn't want to force outfits so if game doesn't like ur selection ( invis body ) it will automatically fix it after couple of seconds , I added Outfit Preset Saving in my local branch plus tattoo editing but tattoo isn't working rn , does not draw . about the preset saving , since it wasn't persistent when I reloaded the game I didn't push it .

To make it persist you need to save the outfit files in .json like yimv1 does (saved_outfits folder) and then the persist outfit would apply on a loop from that ,json outfit.

I personally did not like having the editor in the main UI on YimV1 bc it was so bulky, but i think it'd be ok with this UI as it doesn't overlay over your character.

I mean invisible clothing isn't a big deal and I doubt anyone actually likes how it looks, I personally think the loop should be left out of it. No need to please the public lobby rats. The game also already has a saved outfits option, the source is already out there so I doubt it would be difficult to pull from that instead of JSON.

BegaMetaZone · 2025-04-14T04:05:07Z

yeah exactly what I was going for , since game already has outfit saving system it's not actually needed and about the invis parts or exclusive mask hat combo or long sleeves , I don't want to force a loop of applying outfit .

Fixed Ui And Added Randomize Outfit Button

L7NEG · 2025-04-14T21:54:06Z

maybe this pr will be enough ? BegaMetaZone#1

feat(OutfitEditor): Update

maybegreat48 · 2025-04-15T11:25:39Z

src/game/frontend/submenus/OutfitEditor.hpp

+	public:
+		static std::shared_ptr<YimMenu::Category> CreateCategory();
+
+		static void SetOutfitSlot(int slot, int drawable, int texture);


These don't need to be in the header file

maybegreat48 · 2025-04-15T11:26:20Z

src/game/frontend/submenus/OutfitEditor.hpp

+	class OutfitEditor
+	{
+	public:
+		static std::shared_ptr<YimMenu::Category> CreateCategory();


Should be CreateOutfitsMenu instead, and get rid of the OutfitEditor namespace

Sure I'm working on it

L7NEG · 2025-04-16T12:22:34Z

Done ✅ BegaMetaZone#2

This comment was marked as spam.

Sign in to view

maybegreat48 reviewed Apr 10, 2025

View reviewed changes

src/game/frontend/GUI.cpp Outdated

return;

}

ImGui::Begin("Outfit and Prop Editor");

Copy link

Collaborator

maybegreat48 Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need a separate window

maybegreat48 reviewed Apr 10, 2025

View reviewed changes

BegaMetaZone and others added 2 commits April 12, 2025 00:36

Cleaned up logic and UI placement as per feedback.

d869b6d

Reorganized into a dedicated category under the Self menu (not a separate submenu). Some Error handling and more fixes .

Merge branch 'YimMenu:enhanced' into feature/OutfitEditor

d9fefd3

BegaMetaZone force-pushed the feature/Outfit-Editor branch from b66c55c to d9fefd3 Compare April 11, 2025 22:16

This comment was marked as off-topic.

Sign in to view

feat(OutfitEditor):

0a14b86

Fixed Ui And Added Randomize Outfit Button

Merge pull request #1 from L7NEG/feature/Outfit-Editor

b192c72

feat(OutfitEditor): Update

maybegreat48 reviewed Apr 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/outfit editor #140

Feature/outfit editor #140

BegaMetaZone commented Apr 10, 2025

Psifter commented Apr 10, 2025 •

edited

Loading

yigitboi07 commented Apr 10, 2025

This comment was marked as spam.

maybegreat48 Apr 10, 2025

maybegreat48 Apr 10, 2025

maybegreat48 Apr 10, 2025

maybegreat48 Apr 10, 2025

maybegreat48 Apr 10, 2025

maybegreat48 Apr 10, 2025

maybegreat48 Apr 10, 2025

maybegreat48 Apr 10, 2025 •

edited

Loading

maybegreat48 Apr 10, 2025

maybegreat48 Apr 10, 2025

maybegreat48 Apr 10, 2025

BegaMetaZone Apr 11, 2025

xAzurrr commented Apr 12, 2025

BegaMetaZone commented Apr 12, 2025

Deadlineem commented Apr 13, 2025 •

edited

Loading

BegaMetaZone commented Apr 13, 2025

Deadlineem commented Apr 13, 2025

qwertyuiop11243 commented Apr 14, 2025

BegaMetaZone commented Apr 14, 2025

This comment was marked as off-topic.

L7NEG commented Apr 14, 2025

maybegreat48 Apr 15, 2025

maybegreat48 Apr 15, 2025

L7NEG Apr 16, 2025

L7NEG commented Apr 16, 2025

Feature/outfit editor #140

Are you sure you want to change the base?

Feature/outfit editor #140

Conversation

BegaMetaZone commented Apr 10, 2025

Psifter commented Apr 10, 2025 • edited Loading

yigitboi07 commented Apr 10, 2025

This comment was marked as spam.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maybegreat48 Apr 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xAzurrr commented Apr 12, 2025

BegaMetaZone commented Apr 12, 2025

Deadlineem commented Apr 13, 2025 • edited Loading

BegaMetaZone commented Apr 13, 2025

Deadlineem commented Apr 13, 2025

qwertyuiop11243 commented Apr 14, 2025

BegaMetaZone commented Apr 14, 2025

This comment was marked as off-topic.

L7NEG commented Apr 14, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

L7NEG commented Apr 16, 2025

Psifter commented Apr 10, 2025 •

edited

Loading

maybegreat48 Apr 10, 2025 •

edited

Loading

Deadlineem commented Apr 13, 2025 •

edited

Loading