feat: MinGW compatible build. #562

tupoy-ya · 2022-11-09T04:28:42Z

Reason

MSVC is windows only and using a VM to compile this menu every time you change something isn't nice.

This is what i do to compile it (copy-pasted from CI)

cmake -DCMAKE_BUILD_TYPE:STRING=Release -S. -Bbuild -DCROSSCOMPILE=ON -DUSE_GCC=ON -G Ninja

cmake --build build --config Release

P.s: Some commits from my cmake PR are visible here sorry about that.

chore(logger.cpp): Remove <format> include. refactor(CMakeLists.txt): Tabs to spaces.

working-directory: build/Release/

feat(CMakeLists.txt): Remove debug build.

chore(README.md): Fix typo.

fix(g3log): Ignoring options.

chore(CMakeLists.txt): Remove "Disable warnings" (Needs test in CI). refactor(CMakeLists.txt): Change "BigBaseV2" to "YimMenu". chore: Remove g_is_steam check.

fix(CI): Fix CI trying to access `BigBaseV2.dll` instead of `YimMenu.dll`.

…to feat-cmake-build. That was easier then i expected.

[BigBaseV2](https://github.com/Pocakking/BigBaseV2) mention with [UC](https://www.unknowncheats.me/forum/grand-theft-auto-v/476972-yimmenu-1-63-a.html) one. I hope markdown works.

…to feat-cmake-build.

…/TupoyeMenu into feat-mingw-build.

YimMenu/g3log#4

fix(MSVC): Added some `#if _MSVC_VER` checks.

…to feat-mingw-build. The build will fail, just committing in case i will try to update it again.

chore!: Removed pointers.

…to feat-mingw-build.

tupoy-ya · 2023-06-17T08:52:57Z

I had to remove signature scanning from pointers.cpp because #1227 uses a C++ 20 extension that is not supported by anything except the MSVC compiler. Even Visual Studio doesn't support it.

Is there any other way to implement ptr cache?

xiaoxiao921 · 2023-06-17T08:57:41Z

Yes.

https://godbolt.org/z/5Kdesxfq3

chore: Fix some warnings. Untested.

chore(CI): A little more uniform CI. Untested.

github-actions · 2023-06-17T11:08:14Z

Download the artifacts for this pull request:

Does not link, but at least it compiles fine... I hope. This will probably fail on GitHub because it does not have clang installed. Untested.

…to feat-mingw-build.

Untested.

…to feat-mingw-build.

…to feat-mingw-build. Untested.

Probably works, howewer the GUI isn't rendering. Only the mouse cursor shows.

…to feat-mingw-build.

Untested.

xiaoxiao921 · 2023-11-30T13:11:10Z

What's the reason to not use

msvc-x64-cmake provided by the msvc-wine-git aur package and similar packages? I've had multiple people with Linux under arch systems and similar successfully compiling

tupoy-ya · 2023-11-30T13:27:43Z

What's the reason to not use

msvc-x64-cmake provided by the msvc-wine-git aur package and similar packages? I've had multiple people with Linux under arch systems and similar successfully compiling

I already use msvc-wine, but i want clangd language server and i don't want to run wine all the time.

Right now I'm using clang with msvc headers to compile YimMenu, and the main problem was pointers.cpp.
So I'm just waiting for support from clang, and while I'm waiting I might as well fix everything else, and use the temporary solution of removing the ptr cache.

Ah and also i think cpr did not work with msvc-wine some time ago, but maybe i did something wrong.
EDIT: Also also lua does not compile there after the ImGui bindings.

xiaoxiao921 · 2023-11-30T13:53:22Z

I see, you can fix up pointers.cpp by explicitly using a compile time string struct ( there is one in common.hpp) and not using inline struct declaration inside the template parameters or at least be explicit about the constructor should fix it. For Lua imgui bindings they work under msvc wine, unsure about the other compilers

fix(MinGW): Attent to fix MinGW not building. MinGW fix is untested.

Again.

fix(MinGW): Fixed some mingw error, not that it will build lua without it. Untested.

tupoy-ya added 30 commits November 5, 2022 14:44

refactor!: Replace premake5 with CMake.

5d6c1a3

fix: Submodules.

8f7cc86

fix: CI. I hope.

7e39d5f

chore(logger.cpp): Remove <format> include. refactor(CMakeLists.txt): Tabs to spaces.

fix(CI): Maybe i should remove bash?

c60ec5a

fix(CI): I'm blind.

35c9e6e

working-directory: build/Release/

refactor(CMakeLists.txt)!: Replace git submodules with FetchContent.

cf0e7b0

feat(CMakeLists.txt): Remove debug build.

chore(README.md): Update README.md to have manual updates and CMake.

4632bdb

chore(CMakeLists.txt): Warnings as errors.

97b6c42

fix(script.bat): CMake support, --build option.

9e1ee71

fix(script.bat): Remove --build option i hate DOS and windows.

69493dc

chore(CMakeLists.txt): Clean up.

d2caa03

refactor!: Clean up CMakeLists.txt and move fetch content into includes.

0db332d

chore(README.md): Fix typo.

fix: C++ standard and warning 8028.

88bd5b3

chore(CMakeLists.txt): Remove detected MinSizeRel.

c694679

fix(g3log): Ignoring options.

fix(CMake scripts): All scripts to lowercase.

9de2607

chore(CMakeLists.txt): Allow all build types.

c98207f

chore(CMakeLists.txt): Remove "Disable warnings" (Needs test in CI). refactor(CMakeLists.txt): Change "BigBaseV2" to "YimMenu". chore: Remove g_is_steam check.

refactor!: Replace BigBaseV2/src/ with src/.

05f0784

fix(CI): Fix CI trying to access `BigBaseV2.dll` instead of `YimMenu.dll`.

chore: Merge branch 'master' of https://github.com/YimMenu/YimMenu in…

4882256

…to feat-cmake-build. That was easier then i expected.

refactor(README.md): Replace "original"

983cacd

[BigBaseV2](https://github.com/Pocakking/BigBaseV2) mention with [UC](https://www.unknowncheats.me/forum/grand-theft-auto-v/476972-yimmenu-1-63-a.html) one. I hope markdown works.

feat(MinGW build): MinGW compatible build attemt 2.

2be6b1d

chore: Merge branch 'master' of https://github.com/YimMenu/YimMenu in…

12ff36e

…to feat-cmake-build.

chore: Merge branch 'feat-cmake-build' of https://github.com/tupoy-ya…

3e17cc8

…/TupoyeMenu into feat-mingw-build.

feat(CI): MinGW CI attempt 1.

b1d43e3

fix(CI): Don't use Ninja. Attemt 2.

067fa5a

fix(CI): Go back to C++20. Attemt 3.

c8449fb

fix(g3log): Use custom YimMenu/g3log fork utiil my PR gets merged.

9acd111

YimMenu/g3log#4

fix(CI): Use latest MinGW. Attempt 4.

f5db09b

fix(CI): Install CMake in action. Attempt 5.

1d9645b

fix(CI): Forgot to add uasm. Attempt 6.

eadd69e

fix(CI): Remove Check is DLL got build and use ninja.

795643f

fix(MSVC): Added some `#if _MSVC_VER` checks.

chore: Merge branch 'master' of https://github.com/YimMenu/YimMenu in…

a0a701e

…to feat-mingw-build. The build will fail, just committing in case i will try to update it again.

Yimura mentioned this pull request May 3, 2023

[Bug]: (potentially) only compiling under Windows lib #1326

Closed

1 task

tupoy-ya added 2 commits June 17, 2023 12:15

fix: Fixed some compilation problems.

2ec6647

chore!: Removed pointers.

chore: Merge branch 'master' of https://github.com/YimMenu/YimMenu in…

f8e4d44

…to feat-mingw-build.

tupoy-ya added 2 commits June 17, 2023 15:25

chore(CMakeLists): Remove fmt as it is included with AsyncLogger.

e7a1af7

chore: Fix some warnings. Untested.

fix(MSVC): Attempt to fix MSVC fmt.

8d2005c

chore(CI): A little more uniform CI. Untested.

tupoy-ya and others added 6 commits June 17, 2023 21:50

feat(Clang): Add clang compile support.

16d9681

Does not link, but at least it compiles fine... I hope. This will probably fail on GitHub because it does not have clang installed. Untested.

chore: Merge branch 'master' of https://github.com/YimMenu/YimMenu in…

82854e0

…to feat-mingw-build.

chore(CI): Switch to TupoyeMenu fork if DockerFile

a6c3343

Untested.

chore: Merge branch 'master' of https://github.com/YimMenu/YimMenu in…

d73aff8

…to feat-mingw-build.

chore(CI): Comment out Clang CI.

9c28b95

Merge branch 'master' into feat-mingw-build

e90c0a0

Yimura mentioned this pull request Aug 28, 2023

MinGW compatible build YimMenu/HorseMenu#18

Open

tupoy-ya added 6 commits November 30, 2023 12:54

chore: Merge YimMenu master into feat-mingw-build.

fc290e4

chore: Merge branch 'master' of https://github.com/YimMenu/YimMenu in…

7e901cc

…to feat-mingw-build. Untested.

revert: "Feat: Ptr Cache".

130cc60

Probably works, howewer the GUI isn't rendering. Only the mouse cursor shows.

fix(ImGui): Fix GUI not rendering on clang.

13fcc61

chore: Merge branch 'master' of https://github.com/YimMenu/YimMenu in…

b13adab

…to feat-mingw-build.

refactor(format)!: Use std::format instead of fmt::format.

4a9932a

Untested.

tupoy-ya added 4 commits November 30, 2023 20:21

fix(Compiler Warnings): Fixed some compiler warnings.

951470f

fix(MinGW): Attent to fix MinGW not building. MinGW fix is untested.

fix(MinGW): Attempt at fixing MinGW.

71365ca

Again.

refactor(CI): Remove mingw, possible add clang in msvc mode.

0a6c19a

fix(MinGW): Fixed some mingw error, not that it will build lua without it. Untested.

fix(CI): Possibly make CI start.

e9b011a

Yimura mentioned this pull request Mar 6, 2024

[Build]: Release Build on CLion #2805

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: MinGW compatible build. #562

feat: MinGW compatible build. #562

tupoy-ya commented Nov 9, 2022 •

edited

Loading

tupoy-ya commented Jun 17, 2023

xiaoxiao921 commented Jun 17, 2023

github-actions bot commented Jun 17, 2023 •

edited

Loading

xiaoxiao921 commented Nov 30, 2023 •

edited

Loading

tupoy-ya commented Nov 30, 2023 •

edited

Loading

xiaoxiao921 commented Nov 30, 2023

feat: MinGW compatible build. #562

Are you sure you want to change the base?

feat: MinGW compatible build. #562

Conversation

tupoy-ya commented Nov 9, 2022 • edited Loading

Reason

Additional context

tupoy-ya commented Jun 17, 2023

xiaoxiao921 commented Jun 17, 2023

github-actions bot commented Jun 17, 2023 • edited Loading

xiaoxiao921 commented Nov 30, 2023 • edited Loading

tupoy-ya commented Nov 30, 2023 • edited Loading

xiaoxiao921 commented Nov 30, 2023

tupoy-ya commented Nov 9, 2022 •

edited

Loading

github-actions bot commented Jun 17, 2023 •

edited

Loading

xiaoxiao921 commented Nov 30, 2023 •

edited

Loading

tupoy-ya commented Nov 30, 2023 •

edited

Loading