fix(FontMgr): also keep in mind game language when generating font texture #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
|
@Yimura What is the status of this branch? |
gir489returns
approved these changes
Jul 22, 2024
| "LANGUAGE"_T, | ||
| languages.at((eGameLanguage)session.attributes.language), | ||
| "SESSION_BROWSER_HOST_RID"_T, | ||
| session.info.m_net_player_data.m_gamer_handle.m_rockstar_id, // TODO: this is not accurate |
There was a problem hiding this comment.
@maybegreat48 Why is this not accurate?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR users can have the game set in a different language than the menu and still have the vehicle list properly be rendered.
Closes #2871
Closes #1409