Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protection and made various code improvements. #206

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Protection and made various code improvements. #206

wants to merge 6 commits into from

Conversation

Sys0xdbg
Copy link

@Sys0xdbg Sys0xdbg commented Aug 20, 2024 •
edited by Rxann
Loading

Protection and made various code improvements.
55a18c7 
- Addressed crashes and lag caused by problematic objects.
- Resolved warnings.
- Enabled /MP from faster compiling.
@Rxann
Copy link
Contributor

Rxann commented Aug 20, 2024 •
edited
Loading

You can change the sig to E8 ?? ?? ?? ?? EB 67 48 8B 41 20
Just add 1 and rip

Rxann
Rxann reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Rxann Rxann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to block this on the node level instead of hooking functions for it. Would you be able to track down and reverse the node that is responsible for the crash?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Download the artifacts for this pull request:

Rxann
Rxann previously requested changes Aug 20, 2024
View reviewed changes
src/game/hooks/Protections/PhysicCrash.cpp Outdated Show resolved Hide resolved
src/game/hooks/Protections/ShouldBlockSync.cpp Outdated Show resolved Hide resolved
@Sys0xdbg
Copy link
Author

It's not just this model that crashes; there are others with the same issue. Instead of blocking all models, it would be better to address the problem by hooking.

@Rxann
Copy link
Contributor

Rxann commented Aug 20, 2024

It's not just this model that crashes; there are others with the same issue. Instead of blocking all models, it would be better to address the problem by hooking.

Okay, I would like to test this a good bit before I merge this to ensure that nothing is impacted adversely.

@Rxann Rxann dismissed their stale review August 20, 2024 15:03

Outdated

Rxann
Rxann requested changes Aug 20, 2024
View reviewed changes
src/game/hooks/Protections/PhysicCrash.cpp Outdated Show resolved Hide resolved
src/game/hooks/Protections/PhysicCrash.cpp Outdated Show resolved Hide resolved
src/game/hooks/Protections/PhysicCrash.cpp Outdated Show resolved Hide resolved
src/game/hooks/Protections/PhysicCrash.cpp Outdated Show resolved Hide resolved
src/game/hooks/Hooks.hpp Outdated Show resolved Hide resolved
src/game/hooks/Protections/PhysicCrash.cpp Outdated Show resolved Hide resolved
src/game/hooks/Protections/PhysicCrash.cpp Show resolved Hide resolved
@Rxann
Copy link
Contributor

Rxann commented Sep 8, 2024

Sorry for letting this rot here, I will have more time to test this now.

@Rxann
Copy link
Contributor

Rxann commented Sep 14, 2024

Let me run CI then check this again to ensure quality

@Sys0xdbg Sys0xdbg requested a review from Rxann September 14, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rxann Rxann Awaiting requested review from Rxann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: CS_MP_BOUNTYHUNTER Crash
2 participants
@Sys0xdbg @Rxann