-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add missing yang modules #1647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing yang modules #1647
Conversation
Yeah, I've got a big set of modules to PR. But the damn commit trail is still giving me grief. Let me poke at it some more now. |
Are you syncin'g from IANA's yang-parameters? Their rsync and ftp was broken. I see you've now picked up the new versions of all these yang models except for [email protected] - you're currently hosting [email protected]. BTW, https://www.yangcatalog.org/contribute.html implies that contributions are accepted. |
@pjaitken The contributions noted there are for the Yang Catalog. The "policy" I try to follow is that YangModels/yang contributions are mastered by the owner of the models. In the case of this model the owner is the IETF. If you can coordinate with the IETF and get agreement that they "bless" your changes, that may be fine. But @xorrkaz, as the owner of the automated model update process, has to be onboard. |
The YANG Catalog code only parses the |
@xorrkaz, @pjaitken if errata are being addressed in the module I think it needs to be a new version of the module and hence a new file. I don't know if the IETF yet has a process defined for this? If it is done as a new revision of the model, I'm good with it as long as the IETF is. @xorrkaz, are you able to clarify? (For clarity, what I'm worried about is an automated approach that would see @pjaitken's updates wiped out by the automation...) |
There is a procedure already. IANA is doing this and publishing a new module. In the case of |
In that case, I'll commit this PR (which only adds new revisions) and review the other PR. |
No description provided.