Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When click the course block, lead directly to the course info page #694

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

charleschae12
Copy link
Contributor

When click the course block, lead directly to the course info page issue finished

Animation

ScheduleEvent.csv file edit.
The clickable block works correctly
Feature Request — When click the course block, lead directly to the course info page #693
Copy link

@zhengw5 zhengw5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is really nice however I found an issue with it. When you do click on a course, it did bring me to the correct page, but if you click on the tab schedule again, the schedule disappears until you change something about your selected courses. This problem persists whenever you leave the schedule, and then click the schedule tab again. So I am not sure if it is problem that this feature caused or if this was just an old version.

Copy link
Contributor

@jonha1 jonha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature, but when the user goes back to schedule through the schedule button on the top, schedule disappears unless action was performed upon the schedule. It does work if the user clicks the "back" button.

@charleschae12
Copy link
Contributor Author

The issue is not because of my function, current YACS has the same issue too. But, I will take a look at it if I could fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants