Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

666 schedule disappearing when deselecting course #685

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

littlebizaizi
Copy link

close issue 666.

change the way it find out conflict courses.
So, now it would just treat a course with no section been selected as a blank course.

littlebizaizi and others added 2 commits April 7, 2023 20:46
But still don't know how to fix that, it's so wired right now (randomly appear 1 to 3 courses due to the courses selecting)

Co-Authored-By: xiaxy803 <[email protected]>
Co-Authored-By: doinglin <[email protected]>
Changing the way it find out confliction.

Co-Authored-By: xiaxy803 <[email protected]>
Co-Authored-By: doinglin <[email protected]>
@littlebizaizi littlebizaizi linked an issue Apr 11, 2023 that may be closed by this pull request
Copy link
Contributor

@jonha1 jonha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe an example when this occured

@littlebizaizi
Copy link
Author

After choosing some courses, if there's a course that only contain 1 section inside, unselect that section (not the course) from the "Selected Course" menu.
At this time the whole schedule would just disappear instead of showing the remaining course been selected.

@mlammon11 mlammon11 self-requested a review April 21, 2023 20:15
Copy link
Contributor

@mlammon11 mlammon11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed some issues but didn't resolve others. For example, if you add two courses to schedule, then deselect all sections for both courses, then try to add another class - the 3rd class won't be shown on the schedule, and will only show once re-selecting one of the two original courses. If you could look into this that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule Disappearing When Deselecting Course
3 participants