Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request — Fixed Header Navbar #682 #683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

charleschae12
Copy link
Contributor

Feature Request — Fixed Header Navbar #682 Finished

Issue

Note which issue number(s) this Pull Request closes. All pull requests should close an issue, if one does not exists, make one. This helps us plan and discuss before we decide on implementation

Example:

closes #113

Database Changes/Migrations

If you added/modified a table, notify people of schema change here

Example:

Added table account_semester_selection for a mapping from a students account and semester to a class and section (aka class/section selections)

Test Modifications

Note added unit/integration tests: (all backend changes should contain unit/integration tests with pytest)

Example:

Added test tests/api/db/test_classinfo.py:test_crn_uniqueness to ensure all classes returned from API call don't have repeat CRNs

Test Procedure

Show procedure to test functionality with a clear procedure

Example:

  1. Create a branch
  2. Commit a change to that branch
  3. Push branch
  4. Create Pull Request and fill in PR template

Photos

Show before and after, capture screenshot/gif of finished feature/bug

Additional Info

More info that would help people review your change

Feature Request — Fixed Header Navbar #682 Finished
@dorian451 dorian451 linked an issue Apr 21, 2023 that may be closed by this pull request
@mlammon11 mlammon11 self-requested a review April 21, 2023 20:45
mlammon11
mlammon11 previously approved these changes Apr 21, 2023
Copy link
Contributor

@mlammon11 mlammon11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change but beneficial, looks good!

Copy link
Contributor

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fill out the pull request template, there shouldn't be any examples in there at all

the changes so far look really good!

one problem I found is that the page does not automatically scroll up when switched, which results in the navbar covering content the user probably wants to look at when they switch pages.

could you please make the page scroll up when switching pages?

Added new function so after using the header it will smoothly move back to the top of the new page.
@charleschae12
Copy link
Contributor Author

I have added new Function to smoothly move back up when pressed header!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request — Fixed Header Navbar Ops — Create Pull Request template
3 participants