-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
602 feature request show professor email #677
base: master
Are you sure you want to change the base?
602 feature request show professor email #677
Conversation
Try to print professor name and course section
…thub.com/YACS-RCOS/yacs.n into 602-feature-request-show-professor-email
Try to output professor name and filter duplicate items
Got rid of useless plus sign
…age can add the course
Removed back button from the actual course page since it looked awkward, left it when a course was not found.
Got rid of unnecessary tabs, and put in the correct content within each remaining.
Create a List to store professor name and their email
Changed text and centered it
…rse-page' into 602-feature-request-show-professor-email
…rse-page' into 602-feature-request-show-professor-email
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a pretty useful feature to add because many students email their professors during registration due to conflicts or issues that come up. Choosing the section in this page is also pretty useful but I agree that the schedule should be updated without needing to refresh the webpage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature works in that it will show the professor's name next to each section they teach. However, when we put the section on the schedule display, we cannot scroll down to see which professor teaches that section if the class block is too short to fit all the information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature is a good addition to the website, however I found a bug where if you search the course, for example CSCI 2500, and add it to you schedule, if you click on the hyperlink to see course details, the professors don't show up.
It is works on my computer, could you give me some graph?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly works but for some professors there isn't the correct first and last name, and there's not email. Ex David Goldschmidt teaches CSCI 2500, so If I click on CSCI 2500, "Goldsc" is displayed with no email
Because There are many different name abbreviations that exist in different course databases, I have now added this abbreviation to the professor information and fixed the previous hyperlink problem, try again. |
Now we don't need to refresh |
Somebody did it on different PR |
Yes the hyperlink problem is resolved, but what do you mean by "I have now added this abbreviation to the professor information"? I tried running your branch again and I still see "Goldsc" |
Which semester are you testing for |
Spring 2022 |
This is because the names of professors in the course database are not stored according to the norm, for example: Goldschmidt is abbreviated as Goldsc and Goldschmidt in different courses. this problem may have to be reorganized in the database, now only one can be found, then one can be added. |
Able to show professor name and email on Coursepage and students can add/drop course on Coursepage. If user want to see couse on Schedule page, need to refresh this page.