Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

602 feature request show professor email #677

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

Troy-bailan-King
Copy link
Contributor

Able to show professor name and email on Coursepage and students can add/drop course on Coursepage. If user want to see couse on Schedule page, need to refresh this page.

image
image
image

Troy-bailan-King and others added 30 commits February 14, 2023 16:31
Try to print professor name and course section
Try to output professor name and filter duplicate items
Got rid of useless plus sign
Removed back button from the actual course page since it looked awkward, left it when a course was not found.
Got rid of unnecessary tabs, and put in the correct content within each remaining.
Create a List to store professor name and their email
Changed text and centered it
…rse-page' into 602-feature-request-show-professor-email
…rse-page' into 602-feature-request-show-professor-email
@Troy-bailan-King
Copy link
Contributor Author

Tried to review this pull request however I got this error when I opened the website. Screenshot 2023-04-07 155931

Fix the problem

@aoj624 aoj624 requested a review from chavab0809 April 7, 2023 20:42
Copy link

@zhengw5 zhengw5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a pretty useful feature to add because many students email their professors during registration due to conflicts or issues that come up. Choosing the section in this page is also pretty useful but I agree that the schedule should be updated without needing to refresh the webpage.

Copy link

@zhangn7 zhangn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature works in that it will show the professor's name next to each section they teach. However, when we put the section on the schedule display, we cannot scroll down to see which professor teaches that section if the class block is too short to fit all the information.

@mlammon11 mlammon11 self-requested a review April 8, 2023 18:27
Copy link
Contributor

@mlammon11 mlammon11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is a good addition to the website, however I found a bug where if you search the course, for example CSCI 2500, and add it to you schedule, if you click on the hyperlink to see course details, the professors don't show up.

@Troy-bailan-King Troy-bailan-King dismissed mlammon11’s stale review April 11, 2023 20:59

It is works on my computer, could you give me some graph?

Copy link
Contributor

@mlammon11 mlammon11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly works but for some professors there isn't the correct first and last name, and there's not email. Ex David Goldschmidt teaches CSCI 2500, so If I click on CSCI 2500, "Goldsc" is displayed with no email

@Troy-bailan-King
Copy link
Contributor Author

Goldsc

Mostly works but for some professors there isn't the correct first and last name, and there's not email. Ex David Goldschmidt teaches CSCI 2500, so If I click on CSCI 2500, "Goldsc" is displayed with no email

Because There are many different name abbreviations that exist in different course databases, I have now added this abbreviation to the professor information and fixed the previous hyperlink problem, try again.

@Troy-bailan-King
Copy link
Contributor Author

I think it is a pretty useful feature to add because many students email their professors during registration due to conflicts or issues that come up. Choosing the section in this page is also pretty useful but I agree that the schedule should be updated without needing to refresh the webpage.

Now we don't need to refresh

@Troy-bailan-King
Copy link
Contributor Author

The feature works in that it will show the professor's name next to each section they teach. However, when we put the section on the schedule display, we cannot scroll down to see which professor teaches that section if the class block is too short to fit all the information.

Somebody did it on different PR

@mlammon11
Copy link
Contributor

Yes the hyperlink problem is resolved, but what do you mean by "I have now added this abbreviation to the professor information"? I tried running your branch again and I still see "Goldsc"

@Troy-bailan-King
Copy link
Contributor Author

Which semester are you testing for

@mlammon11
Copy link
Contributor

Which semester are you testing for

Spring 2022

@Troy-bailan-King
Copy link
Contributor Author

Which semester are you testing for

Spring 2022

image

@mlammon11
Copy link
Contributor

Which semester are you testing for

Spring 2022

image

Oop i guess when I refreshed it I forgot to pull from origin, I can see it now. However, there are other courses facing the same issue such as "ARCHITECTURAL DESIGN STUDIO 2" displays "Sehwail" with no email.

@Troy-bailan-King
Copy link
Contributor Author

This is because the names of professors in the course database are not stored according to the norm, for example: Goldschmidt is abbreviated as Goldsc and Goldschmidt in different courses. this problem may have to be reorganized in the database, now only one can be found, then one can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants