640 feature request detailed course page #669
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got rid of useless plus sign
Removed back button from the actual course page since it looked awkward, left it when a course was not found.
Got rid of unnecessary tabs, and put in the correct content within each remaining.
Changed text and centered it
DarknessUnder
approved these changes
Mar 21, 2023
chavab0809
previously approved these changes
Mar 21, 2023
zhangn7
previously approved these changes
Mar 21, 2023
mlammon11
previously approved these changes
Mar 24, 2023
zhengw5
previously approved these changes
Mar 24, 2023
There was a problem hiding this comment.
I tested this function and the tabs are really clean, it seems like a really useful function but you may need to update the syllabus tab multiple times because there are different professors and they might change their syllabus or a new professor may be teaching the class especially for CS courses. This might be a bit of a hassle. The sections part is the most important part, I think it should be the first tab instead of the syllabus.
DarknessUnder
requested changes
Mar 31, 2023
put the sections tab first
ajwadcs
dismissed stale reviews from zhengw5, mlammon11, zhangn7, and chavab0809
via
5e27982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Database Changes/Migrations
Test Modifications
Test Procedure
Photos
Before
After
Additional Info
Made the front end for it. Things like adding in the syllabus to the specific tab or getting Course FAQ require some backend work.