Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select/Remove Course in Explore page #633

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

charleschae12
Copy link
Contributor

Select/Remove Course in Explore page function added.

Issue

Select Course in Explore page
-Added a "Select" button in the
explore page to add the course
easily to the “Selected Courses”
-Afterwards, can check through
“Selected Courses” located in the
sidebar of the first screen, and
can easily choose wanted section.

Remove Course in Explore page
-After press the "Select" button,
it changes to "Remove" button.
-Added "Remove" button which
removes the selected course
-If the course searched are already selected,
the "Remove" button appears first.

chrome-capture-2022-11-9

Register function added.
@charleschae12
Copy link
Contributor Author

Fix Needed:

  • The selected courses do not appear at the schedule right away.
  • The remove button do not appear if you do not select the course at the same page.

jonha1
jonha1 previously approved these changes Feb 7, 2023
Copy link
Contributor

@jonha1 jonha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • well-made feature and easy to use
  • couldn't find any bugs

@mlammon11 mlammon11 self-requested a review February 10, 2023 21:30
Copy link
Contributor

@mlammon11 mlammon11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The course selection button on the explore page works as intended, however, I believe it should provide more feedback to the user.
Some suggestions are:

  • change the background color of the button to green/red for selected/removed
  • add "successfully added/removed" next to the button

Made more user feedback by making button red when it says "Remove"
zhengw5

This comment was marked as outdated.

@zhengw5 zhengw5 removed their assignment Mar 21, 2023
Copy link

@chavab0809 chavab0809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one bug when reviewing the pull request. If you click on the select button for a course and then go to a different page (like the schedule page etc.) and then go back to that selected course it will not say remove, instead it says select again even though you have already selected it.

IMG_7993.MOV

Copy link

@zhangn7 zhangn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As chavab said before, once you leave the current page with the course you selected and then go back to that page to remove it, it will not say remove anymore. It requires you to click "select" and then remove instead of only needing to click remove since the course is already selected.

Copy link

@zhengw5 zhengw5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with chavab and nancy, I checked it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants