Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search issue #623

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Search issue #623

wants to merge 5 commits into from

Conversation

jemanp
Copy link

@jemanp jemanp commented Nov 22, 2022

Issue

I fixed search issues. Before I fixed this function, the search bar does not show the results correctly, but after I fix this, it works by course number, course name, and the abbreviated name of course.

Example:

closes #113

Database Changes/Migrations

If you added/modified a table, notify people of schema change here

Example:

Added table account_semester_selection for a mapping from a students account and semester to a class and section (aka class/section selections)

Test Modifications

Note added unit/integration tests: (all backend changes should contain unit/integration tests with pytest)

Example:

Added test tests/api/db/test_classinfo.py:test_crn_uniqueness to ensure all classes returned from API call don't have repeat CRNs

Test Procedure

Show procedure to test functionality with a clear procedure

Example:

  1. Create a branch
  2. Commit a change to that branch
  3. Push branch
  4. Create Pull Request and fill in PR template

Photos

Show before and after, capture screenshot/gif of finished feature/bug

Additional Info

More info that would help people review your change

tried to changed the text search to auto complete
tried to changed the text search to auto complete
changed the filter
Finished the search function.
It works by department.
It works by course number
It works by full course names
Copy link
Member

@DarknessUnder DarknessUnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't actually fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ops — Create Pull Request template
2 participants