-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tortoise conversion #582
Open
lhain08
wants to merge
99
commits into
master
Choose a base branch
from
TortoiseConversion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tortoise conversion #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update requirements * added session test cases
This reverts commit 841505d.
* Finished first draft of tests for class and department endpoints * Fixed issues with the first draft tests * made recommended changes and added note to class endpoint check about admin non-public semesters
* preliminary fastapi converting * converted to FastAPI * implemented fastapi-cache * removed backup * removed no longer needed commented code * removed no longer needed commented code * converted pytests to use FastAPI TestClient, added automation script * moved markers from conftest to .ini * added documentation for how to update endpoints and added CI for running tests * commented out tests that need updating * added missing requirement * set env variables * automated database cleaning * updated old mock_cache to work for fastapi-cache so old pytests work * uncommented CI step for old pytests
* semester and subsemester tests * updated comments
* Create test_user_course.py * Update test_user_course.py * Update failure case and minor change on success post * Minor changes * Debugging json on line 26 * Passed post success and failure for user/course * Clear comments for pr requirements * Added not authorized test and followed pr requirements
… into FastAPIConversion
* Finished Semester Info Endpoint * Finished Default Semester Endpoint
* added session test cases * test * test user-get success * test user get false * test user put * Fixed test client sessions * delete cookie, using session * delete unrelated comments * add post_user * add test_get_user_after_session_closed * test put user after session closed * remove unrelated code * remove print Co-authored-by: Liam Haining <[email protected]>
…into FastAPIConversion
* converted event model * added models path * commented out old db tests
* converted course_corequisite * converted course_corequisite * updated course model * fixed for pytests * fixed for pytests * workflows * fixed for pytests * fixed for pytests * pytest fixings * forgot to add last changes * pytest fixes * fixed tables init file * course session tortoise conversion first draft (#567) * course session tortoise conversion first draft * fixing some issue * fixed fields Co-authored-by: canghiskhan <calvinang@icloud> Co-authored-by: Liam Haining <[email protected]> Co-authored-by: Liam Haining <[email protected]> Co-authored-by: Liam Haining <[email protected]> Co-authored-by: canghiskhan <[email protected]> Co-authored-by: canghiskhan <calvinang@icloud> Co-authored-by: Liam Haining <[email protected]>
* updated course model * fixed for pytests * fixed for pytests * workflows * fixed for pytests * fixed for pytests * pytest fixings * pytest fixes * course session tortoise conversion first draft (#567) * course session tortoise conversion first draft * fixing some issue * fixed fields Co-authored-by: canghiskhan <calvinang@icloud> Co-authored-by: Liam Haining <[email protected]> Co-authored-by: Liam Haining <[email protected]> * Tortoise conversion coursecorequisite (#574) * converted course_corequisite * converted course_corequisite * forgot to add last changes * fixed tables init file Co-authored-by: PhoenixTamaoki <[email protected]> * Prerequisite model (#570) * beginning tests on course models * progress * bulk upload tests now working * removed database migrations, dependance on sql alchemy * fixed corequisite * Added checks for coreqs Co-authored-by: canghiskhan <[email protected]> Co-authored-by: canghiskhan <calvinang@icloud> Co-authored-by: PhoenixTamaoki <[email protected]> Co-authored-by: franchen28 <[email protected]>
* user-event tortoise conversion * fix * test case * fix bugs * fix bugs * finish test cases; fix original sql error; add a new function: update user event * fix Co-authored-by: Liam Haining <[email protected]>
* convert to tortoise * Update api/app.py, db, tests * Change the db init and import from model * Uncomment/Convert: delete and get methods * Remove unnecessary Import * Delete Comment * Change course_name using $course$%s$course$ * change db_conn to db * Attempt to debug arguments issues * Remove from gitignore * Add await * attempt to debug course_selection in db * Import model in model __init__ file * debugging Co-authored-by: Liam Haining <[email protected]>
* Converted SemesterInfo to Tortoise * finished work on semester info * debugging Co-authored-by: Sachin Khanijow <[email protected]> Co-authored-by: Sachin Khanijow <[email protected]>
* admin_settings tortoise ORM * update the admin_setting * test for admin_setting * debugging * removed commented code Co-authored-by: Xies3 <[email protected]>
* finished app.py * updated tests * Finished Semester Date Range Model * semester date mapping! * worked on map date range tests! * final updates * additions to test map date range * fixed app.py * fixed map date range test Co-authored-by: navyaa-24 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Database Changes/Migrations
Database is converted to Tortoise. This is not something that can be migrated. This should not be important, but merging can be postponed until somebody can take care of the migrations.
Test Modifications
No changes to actual end functionality.