Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon: [1.7.58] - Fix: #589 Spell ranges prefer to use Spell Icon Id over Spell Id #590

Merged
merged 2 commits into from
May 29, 2024

Conversation

Xian55
Copy link
Owner

@Xian55 Xian55 commented May 29, 2024

Since Cataclysm spell ranks have been removed. There are few exceptions such as Shoot/Wand and Auto Shot.

…Id since spell ranks have been removed since Cataclysm. There are few exceptions such as Shoot/Wand and Auto Shot.
@Xian55 Xian55 added the bugfix This pull request fixes an issue. label May 29, 2024
@Xian55 Xian55 changed the title Addon: [1.7.58] - Fix: #589 For spell ranges prefer to use Spell Icon Id over SpellId Addon: [1.7.58] - Fix: #589 Spell ranges prefer to use Spell Icon Id over Spell Id May 29, 2024
@Xian55 Xian55 merged commit 5a84ee3 into dev May 29, 2024
1 check passed
@Xian55 Xian55 deleted the fix/589 branch May 29, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This pull request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DK doesn't attack with abilities due most of the Rank 1 spells have been removed since Cataclysm
1 participant