Addon: [1.7.53] - Fix: improved way to detect kills by honoring cell show time. #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea:
COMBAT_LOG_ITERATION_FRAME_CHANGE_RATE
) is currently 5 update tick. This is tied to the FPS(higher the number it happens more often)COMBAT_LOG_ITERATION_FRAME_CHANGE_RATE
durationThe problem:
damageDone
,damageTaken
,deadGuid
values byCOMBAT_LOG_ITERATION_FRAME_CHANGE_RATE
duration and sometimes ended up showing the cell for 0 or 1 tick time which made the backend impossible to read the values.globalTick
can overflow the 24bit resolution so have to account for negative subtraction. Based on the in-game FPS. With 60fps it can occurs about every 48-72 hours(if i did the math correctly)The new code: