Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon: [1.7.51] - Fix: Respect macro based custom item selling #562

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Xian55
Copy link
Owner

@Xian55 Xian55 commented Jan 8, 2024

Changes:

  • Addon: Refactor sell function logic
  • Core: AdhocNPCGoal: Be sure that pressing the Sell key action before the auto sell junk starts, in order to respect macro based item selling.

Note:

  • The sell function only sells common(grey) and uncommon(white) items.
  • On the other hand uses wild card search, includes everything which contains the given "keyword".
  • When you want to sell Runecloth it going to sell Heavy Runecloth Bandage as well.

Example macro:

/run DataToColor:sell({"Giant Egg","Red Wolf Meat","Jet Black Feather","Vibrant Plume","Runecloth"});

Core: AdhocNPCGoal: Be sure that pressing the Sell key action before the auto sell junk starts, in order to respect macro based item selling.
@Xian55 Xian55 added the bugfix This pull request fixes an issue. label Jan 8, 2024
@Xian55 Xian55 linked an issue Jan 8, 2024 that may be closed by this pull request
@Xian55 Xian55 merged commit b830d50 into dev Jan 8, 2024
1 check passed
@Xian55 Xian55 deleted the fix/vendor-sell-items-via-macro branch January 8, 2024 11:05
@Xian55 Xian55 mentioned this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This pull request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory Management issues (white items)
1 participant