Merging #1
Open
Merging #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In short: async code moved to r2pipe sync module. Now there is no "open" class in __init__.py. It's functionality moved to OpenBase class in open_base.py and modified. Now, instead of using a one class for both of the python version subsets, we import "open" class from the open_sync.py for < 3.0 version, and class with same name from open_async.py for >= 3.0 versions. Those classes are derived from the OpenBase class. Howewer, they have differences. "open" class in open_sync.py -- its just some code, removed from original "open" god object in the old __init__.py script. "open" class in open_async.py -- code, that were used in open_p3.py in r2pipe-async module. TODO: try to use it; find bugs
…rning result from coroutines. Code is working, but still throwing some Ignored exceptions
|
Please send the PR to https://github.com/radare/radare2-r2pipe instead. |
XVilka
reviewed
Mar 19, 2018
| import socket | ||
| import urllib | ||
| from io import TextIOWrapper | ||
| from subprocess import Popen, PIPE | ||
|
|
XVilka
reviewed
Mar 19, 2018
| # -*- coding: utf-8 -*- | ||
| """open_sync.py | ||
| This script use code from old __init__.py open object | ||
|
|
XVilka
pushed a commit
that referenced
this pull request
May 25, 2020
small update open_sync.py (remove utf-8 decodes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Did some work on merging r2pipe/python and r2pipe/python-async (now it's merged in r2/python, but r2pipe/python-async is still there without any changes).
There are still some issues with async code - it's throwing ignored exceptions when "Open" class is destroyed (as I think). Need some help to fix it.
Exception ignored in: <bound method BaseSubprocessTransport.__del__ of <_UnixSubprocessTransport closed pid=4931 running stdin=<_UnixWritePipeTransport closed fd=7 closed> stdout=<_UnixReadPipeTransport closing fd=9 open»>May be related python/asyncio#473