Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to Node 18 and remove cross-fetch #2678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justinr1234
Copy link
Collaborator

High Level Overview of Change

  • Upgrade to node.js 18
  • Remove cross-fetch and use native

Fixes #2676

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update HISTORY.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Automated tests

BREAKING CHANGE: fetch now relies on the native javascript environment in browsers and node.js
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 1.96 MB types

🚮 Removed packages: npm/@types/[email protected], npm/[email protected]

View full report↗︎

@mvadari
Copy link
Collaborator

mvadari commented Apr 15, 2024

This should be done in a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning about punycode on Node.js 21
3 participants