Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linter peer dependencies #2168

Merged
merged 20 commits into from
Feb 7, 2023
Merged

Update linter peer dependencies #2168

merged 20 commits into from
Feb 7, 2023

Conversation

JST5000
Copy link
Collaborator

@JST5000 JST5000 commented Dec 16, 2022

High Level Overview of Change

Fixes a peer dependency mismatch and addresses a couple old Dependabot issues.

Context of Change

Updating dependencies

Type of Change

  • Refactor (non-breaking change that only restructures code)

Before / After

Updated several packages associated with linting.

Test Plan

CI Passes and can build locally

package.json Outdated Show resolved Hide resolved
@JST5000 JST5000 mentioned this pull request Dec 20, 2022
26 tasks
existing.addItem(index, item, leaf)
} else {
throw new Error('invalid ShaMap.addItem call')
if (index !== undefined) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this change from dependabot?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I made these changes - this was to deal with the new version of something not recognizing that assert.ok(index !== undefined) means that index is ok to use later on.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The Dependabot PR is separate & I'll close it once this gets merged :) )

package.json Outdated Show resolved Hide resolved
@socket-security
Copy link

socket-security bot commented Feb 7, 2023

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Ignoring: [email protected], [email protected]

Powered by socket.dev

@justinr1234
Copy link
Collaborator

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

Copy link
Collaborator

@justinr1234 justinr1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all the linting changes? Are those part of the eslint config itself?

@JST5000
Copy link
Collaborator Author

JST5000 commented Feb 7, 2023

Why all the linting changes? Are those part of the eslint config itself?

Yep, they were part of the updated linting config (The 1.9.1 one)

@JST5000 JST5000 merged commit bef2f79 into main Feb 7, 2023
@JST5000 JST5000 deleted the update-lint branch February 7, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants