Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse compatibility with straxen (support both straxen v2 and v3) #298

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cfuselli
Copy link
Member

@cfuselli cfuselli commented Mar 14, 2025

After #282 we were not compatible with older strax and straxen.
Now we address changes needed for being compatible with straxen v2.* and v3.*


  • Check if xnt_common_opts exists or just common_opts, choose accordingly
  • Only do purge_configs if supported
  • Go back to support older strax(en). Now strax = ">=1.6.0" and straxen = ">=2.2.3"

@coveralls
Copy link

coveralls commented Mar 14, 2025

Pull Request Test Coverage Report for Build 14080406402

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 79.937%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fuse/context.py 9 11 81.82%
Totals Coverage Status
Change from base Build 13387532307: -0.03%
Covered Lines: 2538
Relevant Lines: 3175

💛 - Coveralls

@cfuselli cfuselli marked this pull request as ready for review April 3, 2025 12:01
@cfuselli cfuselli requested review from dachengx and HenningSE April 3, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants