xfree86/modes: reduce excess precision xf86ModeHSync and xf86ModeVRefresh #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resh
References:
1. **When to use float vs. double:**
[https://stackoverflow.com/questions/2372744/when-to-use-float-vs-double](https://stackoverflow.com/questions/2372744/when-to-use-float-vs-double)
2. **Floating-Point Performance in C and Fortran:**
[https://www.intel.com/content/www/us/en/developer/articles/technical/floating-point-performance-in-c-and-fortran.html](https://www.intel.com/content/www/us/en/developer/articles/technical/floating-point-performance-in-c-and-fortran.html)
3. **Optimizing Floating Point Code (ARM Developer):**
[https://developer.arm.com/documentation/den0013/d/Optimizing-Floating-Point-Code](https://developer.arm.com/documentation/den0013/d/Optimizing-Floating-Point-Code)
4. **Data Type Optimization in C/C++:**
[https://www.geeksforgeeks.org/data-type-optimization-in-c-cpp/](https://www.geeksforgeeks.org/data-type-optimization-in-c-cpp/)
5. **Why use float instead of double? (Embedded.com):**
[https://www.embedded.com/why-use-float-instead-of-double/](https://www.embedded.com/why-use-float-instead-of-double/)
metux
reviewed
Dec 2, 2025
|
|
||
| extern _X_EXPORT double xf86ModeHSync(const DisplayModeRec * mode); | ||
| extern _X_EXPORT double xf86ModeVRefresh(const DisplayModeRec * mode); | ||
| extern _X_EXPORT float xf86ModeHSync(const DisplayModeRec * mode); |
Contributor
There was a problem hiding this comment.
sorry, but we can't do that - it would break existing drivers.
anything in public headers, with _X_EXPORT is pretty much set in stone (unless we can safely move it out of the SDK/ABI before).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: