Skip to content

dix: initialize all screens before proceeding to gc's, root windows etc #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2025
+7 −0
Merged

dix: initialize all screens before proceeding to gc's, root windows etc #1479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dix/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,18 @@ dix_main(int argc, char *argv[], char *envp[])
FatalError("failed to create screen resources");
});

/* Let all screens register the necessary privates */

DIX_FOR_EACH_SCREEN({
if (!PixmapScreenInit(walkScreen))
FatalError("failed to create screen pixmap properties");
if (!dixScreenRaiseCreateResources(walkScreen))
FatalError("failed to create screen resources");
});
Copy link
Contributor

@metux metux Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theoretically it should be possible to register privates even if some objects already existing (their private areas should be resized automatically) ... but somehow it doesn't seem to work as intended.

is this also happening on 25.0 ?


/* Then use these privates to initialize root windows etc */

DIX_FOR_EACH_SCREEN({
if (!CreateGCperDepth(walkScreen))
FatalError("failed to create scratch GCs");
if (!CreateDefaultStipple(walkScreen))
Expand Down