Skip to content

render: drop internal server reset support #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

render: drop internal server reset support #1448

wants to merge 1 commit into from

Conversation

@metux
Copy link
Contributor

@metux metux commented Nov 20, 2025

Signed-off-by: Enrico Weigelt, metux IT consult [email protected]

@metux metux self-assigned this Nov 20, 2025
metux added a commit that referenced this pull request Nov 20, 2025
@metux
[PR #1448] render: drop internal server reset support
dd444fd 
PR: #1448
stefan11111
stefan11111 reviewed Nov 20, 2025
View reviewed changes
render/picture.c
CARD32 type, a, r, g, b;

if (PictureGeneration != serverGeneration) {
{
Copy link
Contributor

@stefan11111 stefan11111 Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the extra scope block?

Copy link
Contributor Author

@metux metux Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just didn't want to add lots of indention changes here ...

metux added a commit that referenced this pull request Nov 21, 2025
@metux
[PR #1448] render: drop internal server reset support
542d5b0 
PR: #1448
metux added a commit that referenced this pull request Nov 21, 2025
@metux
[PR #1448] render: drop internal server reset support
c4ffb08 
PR: #1448
@metux
render: drop internal server reset support
ed3527c 
Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
@metux metux force-pushed the pr/render-drop-internal-server-reset-support-_2025-11-20_16-37-24 branch from cbb5dfe to ed3527c Compare November 21, 2025 14:55
@metux
Copy link
Contributor Author

metux commented Nov 21, 2025

had to change it once more: PictureInit indeed can be called multiple times (eg. for each screen), but certain things in here must only be done once. using a boolean flag now.

@stefan11111
Copy link
Contributor

stefan11111 commented Nov 21, 2025

had to change it once more: PictureInit indeed can be called multiple times (eg. for each screen), but certain things in here must only be done once. using a boolean flag now.

Perhaps we should add such flags to other init functions?

@metux
Copy link
Contributor Author

metux commented Nov 22, 2025

had to change it once more: PictureInit indeed can be called multiple times (eg. for each screen), but certain things in here must only be done once. using a boolean flag now.

Perhaps we should add such flags to other init functions?

to those who need it.

metux added a commit that referenced this pull request Nov 27, 2025
@metux
[PR #1448] render: drop internal server reset support
f27b658 
PR: #1448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefan11111 stefan11111 stefan11111 left review comments

@mikedld mikedld Awaiting requested review from mikedld

@jonhermansen jonhermansen Awaiting requested review from jonhermansen

@josephcrowell josephcrowell Awaiting requested review from josephcrowell

@cepelinas9000 cepelinas9000 Awaiting requested review from cepelinas9000

@algrid algrid Awaiting requested review from algrid

@callmetango callmetango Awaiting requested review from callmetango

@b-aaz b-aaz Awaiting requested review from b-aaz

@ONykyf ONykyf Awaiting requested review from ONykyf

Assignees

@metux metux

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@metux @stefan11111