Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated BoneCP (#166). #179

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

karelmaxa
Copy link
Member

This PR completely removes support for the deprecated BoneCP, which has been replaced by HikariCP. I have not found any reason why we should keep this dependency in our project.

Copy link
Member

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This has important repercussion for upgrade compatibility in a sense that it is not possible to go from 4.x to 7.x directly (or with a warning about bonecp). Keep that in mind when updating wrenidm-doc.

@pavelhoral pavelhoral merged commit 44f259a into WrenSecurity:main Mar 12, 2024
2 checks passed
@karelmaxa karelmaxa deleted the remove-bonecp branch March 13, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants