Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Item: Add layout support #69219

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

SainathPoojary
Copy link
Contributor

Part of: #43248

What?

Added Layout support to the List Item Block.

Why?

The block was missing Layout Support Features.

Testing Instructions

  1. Test the List Item block in both the block editor and site editor.
  2. Confirm that the layout setting work correctly, and display correctly on the front.

Screencast

Screen.Recording.2025-02-17.at.3.39.53.PM.mov

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Page List Affects the Page List Block [Feature] Layout Layout block support, its UI controls, and style output. labels Feb 18, 2025
@SainathPoojary SainathPoojary marked this pull request as ready for review February 18, 2025 06:13
Copy link

github-actions bot commented Feb 18, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

carolinan commented Feb 18, 2025

I don't think layout support is suitable for this block.
I want to ask the same question as for the submenu, why does the block need layout support?

Why is there a wide content width option, when the block can not be wide?
For this block, I think the text alignment option (the justification) is confusing, because it makes it more difficult to identify which list items that are nested. Because the position of the item is how we usually determine if an item is nested, together with the bullet.
Overall I found it a confusing experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Page List Affects the Page List Block [Feature] Layout Layout block support, its UI controls, and style output. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants