Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query No Results: Add layout support #69217

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Query No Results: Add layout support #69217

wants to merge 1 commit into from
+2 −1

Conversation

Infinite-Null
Copy link
Contributor

Part of: #43248

What?

Added Layout support to the Query No Results Block.

Why?

The block was missing Layout Support Features.

How?

Testing Instructions

  1. Test the Query No Results block in both the block editor and site editor.
  2. Confirm that the layout setting work correctly, and display correctly on the front.

Screencast

Screen.Recording.2025-02-17.at.2.53.24.PM.mov

@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Infinite-Null Infinite-Null marked this pull request as draft February 17, 2025 09:37
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Feature] Layout Layout block support, its UI controls, and style output. [Block] No Results Affects the No Results Block - used when a Query Loop returns no results labels Feb 18, 2025
@Infinite-Null Infinite-Null marked this pull request as ready for review February 18, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Block] No Results Affects the No Results Block - used when a Query Loop returns no results [Feature] Layout Layout block support, its UI controls, and style output. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Infinite-Null @Mamaduka