Editor: Avoid a 'flash' when rendering in 'template-locked' mode #69173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Regression
|
Size Change: +12 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 91c194e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13301878019
|
Mamaduka
force-pushed
the
try/fix-rendering-mode-flash
branch
from
91c194e to
46c5751
Compare
Mamaduka
force-pushed
the
try/fix-rendering-mode-flash
branch
from
46c5751 to
e9bced2
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This is ready for testing. cc @WordPress/gutenberg-core |
fabiankaegy
approved these changes
Feb 17, 2025
2 tasks
|
Thanks, @fabiankaegy! Note: First, I'll need to land #69106. Otherwise, pages won't be loading correctly for low-capability users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69088.
Requires #69106.
PR tries to fix the editor rendering mode "flash" by delaying rendering until the page template resolves when the default rendering mode is
template-locked.Why?
See: #69088.
Todos
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast