Generate built CSS file containing the admin color theme CSS custom properties #69128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 3rd parties and WordPress Core
fabiankaegy
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
karmatosed
reviewed
Feb 15, 2025
t-hamano
reviewed
Feb 17, 2025
Co-authored-by: Aki Hamano <[email protected]>
|
Flaky tests detected in 65d1b0f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13364508506
|
|
The code looks good. Is this CSS file going to be bundled with WP 6.8? If so, it is my understanding that during the 6.8 cycle, the following tasks will need to be performed in order:
cc @Mamaduka for visibility: We are trying to generate a CSS file for the admin color scheme from the |
|
@t-hamano yeah that exactly is what my plan looked like :) From my perspective 6.8 is not a required target as we won't really have enough time to fully utilize the base styles there. But I also don't see any harm in starting the inclusion |
t-hamano
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
For now, I think there should be no problem with shipping this PR. Once the new @wordpress/base-styles package is released, let's check to see if the CSS file is in the following path:
node_modules/@wordpress/base-styles/build-style/admin-schemes.css
- Enqueue the built
admin-schemes.css.
- Gutenberg plugin: Move #69130 forward.
- Core: Enqueue
admin-schemes.cssand add thewp-admin-schemeshandle to the_wp_get_iframed_editor_assets()function
Regarding this step, both tasks need to be addressed in one major WordPress release, otherwise in WordPress without the Gutenberg plugin enabled, the color scheme may not be applied in the block editor etc. because the CSS file for the color scheme does not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a new build CSS file to the
@wordpress/base-stylespackage that includes the admin color scheme CSS custom properties.Why?
Today these styles are duplicated in several packages individually. And WordPress Core doesn't use the CSS custom properties at all. We want to change that.
This is the first step in adopting these custom properties across all of WordPress.
The next steps after this has been merged are:
wp-base-styleshandle in WordPress Core (can also happen separately in Gutenberg)wp-base-stylesdependency when the stylesheet gets registered.How?
By adding a new
src/admin-schemes.scssfile, which gets picked up by the build process and, therefore, built and published with the NPM package.