Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: fix property modification backport to 6.7.2 #67259

Open
wants to merge 1 commit into
base: wp/6.7
Choose a base branch
from

Conversation

cbravobernal
Copy link
Contributor

What?

Backports #66872 to wp/6.7 to release WP 6.7.2.
I also fixed some TS errors that are already in trunk.

…wo or more levels above (#66872)

* Add failing test

* Fix code

* Add changelog entry

* Define "modal" prop in submenu context

Co-authored-by: DAreRodz <[email protected]>
Co-authored-by: sirreal <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>
Co-authored-by: danielpost <[email protected]>
@cbravobernal cbravobernal added [Type] Bug An existing feature does not function as intended Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release [Packages] Interactivity /packages/interactivity labels Nov 24, 2024
@cbravobernal cbravobernal self-assigned this Nov 24, 2024
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: cbravobernal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release [Packages] Interactivity /packages/interactivity [Type] Bug An existing feature does not function as intended
Projects
Status: 🔎 Needs Review
Development

Successfully merging this pull request may close these issues.

1 participant