Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure consistency in editor tools for navigation buttons and delete options #67253

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

sarthaknagoshe2002
Copy link
Contributor

@sarthaknagoshe2002 sarthaknagoshe2002 commented Nov 23, 2024

Fixes: #63991

What?

This PR addresses inconsistencies in the editor tools UI, focusing on:

Navigation Button Design: Ensures consistent use of chevrons for menu items like Shadows and Typography/Font Sizes, which navigate to edit screens.
Delete All Options: Adds or aligns "Delete All" functionality for custom settings like Shadows, Custom Font Sizes, and Colors.

Why?

Inconsistent UI elements create confusion for users and hinder the overall experience. Aligning the design and functionality of editor tools improves usability, accessibility, and coherence across the interface.

How?

Updated navigation button components to uniformly display chevrons for items that navigate to sub-settings (e.g., Shadows, Typography/Font Sizes).
Implemented consistent "Delete All" options for applicable settings, ensuring uniform behavior across Shadows, Custom Font Sizes, and Colors.
Adjusted CSS and component logic for styling and interactions to reflect these changes.

Testing Instructions

  1. Navigation Buttons

    • Check that Shadows and Typography/Font Sizes now show chevrons consistently.
  2. Delete All Options

    • Verify the "Delete All" option exists and works for Shadows, Custom Font Sizes, and Colors.

Screenshots or screencast

editor-shadow.options.mov

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sarthaknagoshe2002 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent UI in editor settings
1 participant