Disable Zoom Out if no section root to allow for Theme opt in #67232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
getdave
requested review from
draganescu,
talldan,
jeryj,
richtabor,
MaggieCabrera,
ajlende and
annezazu
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +52 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
jeryj
reviewed
Nov 22, 2024
|
Something like this? https://github.com/WordPress/gutenberg/pull/67245/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Disable Zoom Out if no section root to allow for Theme opt in by defining a `
zRelated to #67113.
Why?
Because reports have been coming in that the block layout of some Themes isn't compatible with a good experience in Zoom Out.
How?
With this change if a
<main>tag is not defined (or we're not editing a entity with acore/post-contentblock) then Zoom Out will be disabled.This allows Themes to opt in to Zoom Out based on where they place a
<main>tag. If no<main>is defined then Zoom Out will not work.Testing Instructions
<main>from templateTesting Instructions for Keyboard
Screenshots or screencast