Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Restore stable components back into categories #67216

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

mirka
Copy link
Member

@mirka mirka commented Nov 21, 2024

What?

Puts these stable components into the category groupings:

  • CustomSelectControl
  • DropdownMenu (and MenuItem, MenuGroup, MenuItemChoice)
  • TextControl

Why?

In #66275, a handful of components were prematurely left out of the category groupings, even though they are the currently stable component to be used for certain things. I think they were left out because there are v2 components in development, but the v2 ones aren't ready for public use yet so we can't deemphasize the v1 components.

Testing Instructions

See Storybook. Permalinks should not be broken.

@mirka mirka added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components Storybook Storybook and its stories for components labels Nov 21, 2024
@mirka mirka requested review from auareyou and a team November 21, 2024 23:48
@mirka mirka self-assigned this Nov 21, 2024
Copy link

github-actions bot commented Nov 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Confirming all stories live where they should be and URLs are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants