Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python packaging using latest methods #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hsbasu
Copy link

@hsbasu hsbasu commented Jun 9, 2022

@brlin-tw
Copy link
Member

brlin-tw commented Jun 9, 2022

Please separate your changes into individual pull requests, each change should have a rationale to indicate why those changes are necessary and/or beneficial to the project.

@brlin-tw brlin-tw closed this Jun 9, 2022
@hsbasu
Copy link
Author

hsbasu commented Jun 9, 2022

If I follow the latest python packaging guide (Link in Commit), this is the minimal change that was required. I just moved the sources to src and added latest python packaging methods i.e. adding the setup.cfg and pyproject.toml.

@brlin-tw brlin-tw reopened this Jun 9, 2022
@brlin-tw
Copy link
Member

brlin-tw commented Jun 9, 2022

Got it, thanks for the explanation.

@hsbasu
Copy link
Author

hsbasu commented Jun 9, 2022

Please separate your changes into individual pull requests, each change should have a rationale to indicate why those changes are necessary and/or beneficial to the project.

The changes were required, as I mentioned in commit, to package it for debian and others.

@hsbasu
Copy link
Author

hsbasu commented Jun 9, 2022

I would suggest do not merge it yet. because the setup.py needs to be cleaned. It would be highly appreciated if you could test the branch. just use pip3 install .. no need to use sudo

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@hsbasu
Copy link
Author

hsbasu commented Jun 9, 2022

I would also suggest while merging use the Squash and merge option rather than creating a new commit

Copy link
Author

@hsbasu hsbasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brlin-tw All changes are resolved. It might need virtualenv and build (on debian python3-virtualenv and python3-build) package to build.

@hsbasu
Copy link
Author

hsbasu commented Jun 13, 2022

@brlin-tw you can merge the branch. I have completed all the necessary changes and it works fine.

@hsbasu
Copy link
Author

hsbasu commented Jul 23, 2022

@brlin-tw A gente reminder that the PR is ready for merge. Thank you.

@hsbasu
Copy link
Author

hsbasu commented Feb 15, 2023

@brlin-tw Hi. Is this PR going to get merged or should I close this as incomplete?

@WaxyMocha WaxyMocha self-assigned this Feb 19, 2023
@WaxyMocha
Copy link
Member

Hi @hsbasu, thanks for PR.
I'm sorry for ignoring this, I had a lot on my head for some time now. I'll try to go over those changes as soon as possible.

- Change python packaging method following instructions from
  https://packaging.python.org/en/latest/tutorials/packaging-projects
- Remove scripts as they can be created automatically from setup.cfg
- move the sources to src
- setup.py: remove captialization in package names, conflicts with other
  packaging methods like debian's
- modify licence to gpl3+
- Add setup.cfg and pyproject.toml
- modify MANIFEST.in to include assets
- WoeUSB-ng.desktop: add version and change icon; fixes WoeUSB#11
@BarbUk
Copy link

BarbUk commented Jul 1, 2023

FYI, I use this PR without issue to build the aur package available at https://aur.archlinux.org/packages/woeusb-ng.

The pkgbuild file that show the build process is available here.

I'll subscribe to this thread to be notified about the merge to update the package.
I can provide help with test or feedback for this PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WoeUSB-ng GUI does not work with GNOME on some distributions
4 participants