Move all Relationship references to single dataclass Relationship
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes bug in `attack_paths.py` where POD was used
instead of PODS (due to internals pluralizing resources)
Skybound1
reviewed
Dec 5, 2023
* Format code using `poetry run black .`
Skybound1
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
attack_paths.pywhere POD was used instead of PODS (due to internals pluralizing resources)Summary
This is the start of a series of PRs that aim to improve the codebase, functionality, and make onboarding new object types easier. I will be writing the next PRs using this branch, and rebase the next branch once this one is merged into main.
Progress will be tracked here: Add support for PersistentVolume resource kind #10
I will be updating the message to reflect the status of migrating certain features/bug fixes.
More PRs to come later tonight