Add Default Locale Option to enable x-default #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielDarrenJones Thanks for the contribution! All seems to work well - just a couple of small changes requested 🙂 |
|
@joshuanoyes Sorry if I am being silly, but I don't seem to be able to see the requested changes? |
joshuanoyes
approved these changes
Jan 26, 2024
|
@DanielDarrenJones Sorry, forgot to press "Submit review"! |
|
@joshuanoyes both of these should be resolved now, as strict type checks, thanks! |
|
@DanielDarrenJones Thanks - we will include this in a release on Monday 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new general config option to select a site as the default locale, this will then add the x-default hreflang tags to the html.
See: https://developers.google.com/search/blog/2013/04/x-default-hreflang-for-international-pages
Implements: #82
Please let me know if you would like this done in a different way or need any amendments, this is a first draft just to get the ball rolling.