Open
Conversation
When parse_expression failed to consume any tokens during tuple
element collection (e.g. for input `(,{`), the forward-progress
assertion aborted the parser. Break out of the loop instead so
the diagnostic is reported normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a parser panic that occurred when parsing malformed tuple literals where the parser failed to make forward progress after recovering from an invalid element.
Changes
parse_tuple_literal_or_parenthesesto a conditional check that breaks the parsing loop whenparse_expressionfails to consume any tokens, preventing infinite loops during error recoverytuple_no_progress.gdntest file to verify the parser correctly handles malformed input like(,{and emits appropriate diagnostics without panickingImplementation Details
The issue occurred because when
parse_expressionencountered an error and couldn't consume any tokens, the parser would remain at the same position and attempt to parse the next tuple element infinitely. The fix detects this condition and breaks out of the loop, allowing the parser to continue gracefully with error recovery already handled by the diagnostic system.https://claude.ai/code/session_01Smbrb7sx8HkXRUkSXNLfme