Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kill buffer key binding #42

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Remove kill buffer key binding #42

merged 1 commit into from
Aug 31, 2023

Conversation

wyuenho
Copy link
Contributor

@wyuenho wyuenho commented Aug 31, 2023

elisp-refs-mode derives from special-mode, which already has q bound to quit-window. Most special mode derivatives leave this alone so quit-restore-window can decide what's the right thing to do next. With q bound to kill-buffer, quit-restore-window doesn't have a chance to run and leaves a duplicate window showing some already shown buffer when window managers like window-purpose is active.

@Wilfred
Copy link
Owner

Wilfred commented Aug 31, 2023

Makes sense, thanks!

@Wilfred Wilfred merged commit 9b6839c into Wilfred:master Aug 31, 2023
5 checks passed
@wyuenho wyuenho deleted the patch-1 branch August 31, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants