Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve overloading algorithm #98

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

WhyAsh5114
Copy link
Owner

@WhyAsh5114 WhyAsh5114 commented Sep 18, 2024

Description

Make some changes to the overloading algorithm to improve rep suggestions and set increases.
Fixes #93, #90, #85, #84

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • test_file.spec.ts > should_do_task_1
  • test_file.spec.ts > should_do_task_2

Tasks

  • Replace the Brzycki formula with the Berger formula
  • Better load increase criteria (make repRangeEnd a soft limit and lower repRangeStart a hard limit)
  • Don't increase sets or reps for Cycle 2, can overdo progression easily
  • Don't add sets if already reached max volume for the specified muscle group for that microcycle
  • Distribute new sets evenly across exercises
  • Use (reps + RIR) * load for average drop-off calculation
  • Include mini sets in volume calculation
  • Proper progression for each set type
  • Add tests for common exercises to ensure no weird behavior

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
my-fit-jgqg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 4:13pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v3-enhancement New feature or request for v3
Projects
None yet
1 participant