Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Unicode EN+Space for Space #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vincentkoc
Copy link

Fix for #96

@coveralls
Copy link

coveralls commented Jan 19, 2019

Coverage Status

Coverage remained the same at 99.976% when pulling 17686ef on koconder:dev-unicode into 9c6ad8e on WhichBrowser:master.

vincentkoc added a commit to vincentkoc/Parser-JavaScript that referenced this pull request Jan 20, 2019
Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106
vincentkoc added a commit to vincentkoc/Parser-JavaScript that referenced this pull request Jan 22, 2019
Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106
mariotsi added a commit to WhichBrowser/Parser-JavaScript that referenced this pull request Feb 6, 2019
#33)

* Removing Unicode EN+Space for Space

Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106

* Removing Unicode EN+Space for Space

Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106

* Now update-profiles.js and update-models.js strip away EN+SPACE character  as requested on #32

* Revert changes to data files. These files are automatically generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants