-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(ui): Instance customization for bootstrap 5 templates #16526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is nearly ready to merge but I think it will need a more complete refactor once the Bootstrap 5 migration is finished as doing this in a way that works for both BS3 and BS5 templates is quite difficult. One incomplete part is the |
|
@nijel maybe we can remove the |
|
We can also keep it non-working for now if this is the only thing blocking this. Removing it would remove the existing setting for users, which would be annoying if we plan to reintroduce it. |
This PR updates the custom CSS template used by the appearance customization feature to work with the new Bootstrap 5 templates.
Part of #2916
Fixes #16912