Skip to content

Conversation

@KarenKonou
Copy link
Contributor

@KarenKonou KarenKonou commented Oct 11, 2025

This PR updates the custom CSS template used by the appearance customization feature to work with the new Bootstrap 5 templates.

Part of #2916
Fixes #16912

@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.71%. Comparing base (a368da8) to head (03e5c48).
⚠️ Report is 149 commits behind head on main.

Files with missing lines Patch % Lines
weblate/configuration/templatetags/colors.py 80.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nijel nijel added this to the 5.14.1 milestone Oct 24, 2025
@KarenKonou KarenKonou changed the title WIP: feat(ui): Instance customization for bootstrap 5 templates feat(ui): Instance customization for bootstrap 5 templates Oct 29, 2025
@KarenKonou
Copy link
Contributor Author

This is nearly ready to merge but I think it will need a more complete refactor once the Bootstrap 5 migration is finished as doing this in a way that works for both BS3 and BS5 templates is quite difficult.

One incomplete part is the enforce hamburger option. In BS5 this should be achievable simply by removing the .navbar-expand class which can be easily done with JS but I'm not sure what the best way to trigger the script is. Ideas welcome.

@nijel nijel modified the milestones: 5.14.1, 5.15 Nov 5, 2025
@nijel nijel linked an issue Nov 13, 2025 that may be closed by this pull request
2 tasks
@KarenKonou
Copy link
Contributor Author

@nijel maybe we can remove the enforce hamburger option for now just to make this mergeable and readd it later?

@nijel nijel modified the milestones: 5.15, 5.15.1 Dec 15, 2025
@nijel
Copy link
Member

nijel commented Dec 15, 2025

We can also keep it non-working for now if this is the only thing blocking this. Removing it would remove the existing setting for users, which would be annoying if we plan to reintroduce it.

@KarenKonou KarenKonou marked this pull request as ready for review December 15, 2025 13:14
@KarenKonou KarenKonou requested a review from nijel as a code owner December 15, 2025 13:14
@nijel nijel enabled auto-merge (squash) December 15, 2025 13:19
@nijel nijel disabled auto-merge December 15, 2025 13:19
@nijel nijel enabled auto-merge (squash) December 15, 2025 13:19
@nijel nijel disabled auto-merge December 15, 2025 13:19
@nijel nijel enabled auto-merge (squash) December 15, 2025 13:20
@nijel nijel disabled auto-merge December 15, 2025 13:20
@nijel nijel enabled auto-merge (squash) December 15, 2025 13:20
@nijel nijel disabled auto-merge December 15, 2025 13:20
@nijel nijel enabled auto-merge (squash) December 15, 2025 13:58
@nijel nijel self-assigned this Dec 15, 2025
@nijel nijel modified the milestones: 5.15.1, 5.15 Dec 15, 2025
@nijel nijel disabled auto-merge December 15, 2025 13:59
@nijel nijel merged commit 1a40b88 into WeblateOrg:main Dec 15, 2025
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Appearearance changes no longer apply everywhere

2 participants