fix: allow resetting fullscreen client to nullptr #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcatanzaro
reviewed
Nov 7, 2023
|
Can you squash your changes into one commit please? |
yury-s
force-pushed
the
allow-resetting-fullscreen-client
branch
from
7564ae7 to
5172090
Compare
Done. We usually rely on GitHub doing it, which is why I just pushed one on top. |
|
Looks good now, but I'm not a maintainer so can't merge. |
yury-s
force-pushed
the
allow-resetting-fullscreen-client
branch
from
5172090 to
8b6fd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid crashes like https://bugs.webkit.org/show_bug.cgi?id=264360 we need to reset wpe backend clients (see this PR) and the assert in
wpe_view_backend_set_fullscreen_clientdid not allow that.