Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger should have a virtual destructor #28820

Merged
merged 1 commit into from
May 21, 2024
Merged

Logger should have a virtual destructor #28820

merged 1 commit into from
May 21, 2024

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented May 21, 2024 •
edited by webkit-early-warning-system

7d4bbc7

Logger should have a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=274432

Reviewed by David Kilzer and Chris Dumez.

Added the virtual destructor since AggregateLogger subclasses Logger
and has non-POD member variables.

* Source/WTF/wtf/Logger.h:
(WTF::Logger::~Logger):

Canonical link: https://commits.webkit.org/279033@main

4fefda6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
  🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ❌ 🧪 jsc-armv7-tests

@rniwa rniwa self-assigned this May 21, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 4fefda6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
  🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ❌ 🧪 jsc-armv7-tests

ddkilzer
ddkilzer approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@ddkilzer ddkilzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 21, 2024
@rniwa
Logger should have a virtual destructor
7d4bbc7 
https://bugs.webkit.org/show_bug.cgi?id=274432

Reviewed by David Kilzer and Chris Dumez.

Added the virtual destructor since AggregateLogger subclasses Logger
and has non-POD member variables.

* Source/WTF/wtf/Logger.h:
(WTF::Logger::~Logger):

Canonical link: https://commits.webkit.org/279033@main
@webkit-commit-queue
Copy link
Collaborator

Committed 279033@main (7d4bbc7): https://commits.webkit.org/279033@main

Reviewed commits have been landed. Closing PR #28820 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7d4bbc7 into WebKit:main May 21, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 21, 2024
@rniwa rniwa deleted the fix274432 branch May 21, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddkilzer ddkilzer ddkilzer approved these changes

@cdumez cdumez cdumez approved these changes

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@rniwa rniwa

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@rniwa @webkit-early-warning-system @webkit-commit-queue @ddkilzer @cdumez