-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[view-transitions] Mispositioned snapshots on https://codepen.io/bramus/full/mdowgYX #28808
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mattwoodrow:eng/vt-fixed-position
May 23, 2024
Merged
[view-transitions] Mispositioned snapshots on https://codepen.io/bramus/full/mdowgYX #28808
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mattwoodrow:eng/vt-fixed-position
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 0a8c299) |
mattwoodrow
added
the
Layout and Rendering
For bugs with layout and rendering of Web pages.
label
May 20, 2024
mattwoodrow
force-pushed
the
eng/vt-fixed-position
branch
from
May 20, 2024 22:45
0a8c299
to
33d9153
Compare
EWS run on previous version of this PR (hash 33d9153) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 21, 2024
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 21, 2024
mattwoodrow
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 22, 2024
mattwoodrow
force-pushed
the
eng/vt-fixed-position
branch
from
May 22, 2024 02:45
33d9153
to
85d5853
Compare
EWS run on previous version of this PR (hash 85d5853) |
smfr
approved these changes
May 22, 2024
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 22, 2024
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 22, 2024
mattwoodrow
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 23, 2024
mattwoodrow
force-pushed
the
eng/vt-fixed-position
branch
from
May 23, 2024 02:33
85d5853
to
dd507bc
Compare
EWS run on previous version of this PR (hash dd507bc) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 23, 2024
mattwoodrow
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 23, 2024
mattwoodrow
force-pushed
the
eng/vt-fixed-position
branch
from
May 23, 2024 04:15
dd507bc
to
13f3033
Compare
EWS run on current version of this PR (hash 13f3033) |
webkit-commit-queue
force-pushed
the
eng/vt-fixed-position
branch
from
May 23, 2024 09:06
13f3033
to
4556803
Compare
β¦us/full/mdowgYX https://bugs.webkit.org/show_bug.cgi?id=272185 rdar://125931829 Reviewed by Simon Fraser. We were previously unconditionally substracting the scroll position from the transform when positioning the snapshots. This is incorrect in some cases, like when the element is fixed positioned. This makes use of the existing TransformState/mapLocalToContainer code to correctly account for position:fixed when accumulating transforms through ancestors. It also adds support for flattening the 'tracked' transform when crossing 3d rendering context boundaries, by setting the 3rd row and column of the TransformationMatrix to 0. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-flat-transform-ancestor-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-flat-transform-ancestor-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-flat-transform-ancestor.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-preserve-3d-ancestor-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-preserve-3d-ancestor-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-preserve-3d-ancestor.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-transform-position-fixed-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-transform-position-fixed-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-transform-position-fixed.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background.html: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::copyElementBaseProperties): * Source/WebCore/platform/graphics/transforms/TransformState.cpp: (WebCore::TransformState::translateMappedCoordinates): (WebCore::TransformState::flattenWithTransform): * Source/WebCore/platform/graphics/transforms/TransformState.h: * Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::flatten): * Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::localToAbsoluteTransform const): * Source/WebCore/rendering/RenderObject.h: Canonical link: https://commits.webkit.org/279186@main
webkit-commit-queue
force-pushed
the
eng/vt-fixed-position
branch
from
May 23, 2024 09:08
4556803
to
159906e
Compare
Committed 279186@main (159906e): https://commits.webkit.org/279186@main Reviewed commits have been landed. Closing PR #28808 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
159906e
13f3033
π§ͺ wpe-wk2π§ͺ ios-wk2π§ͺ ios-wk2-wptπ§ͺ api-iosπ§ͺ gtk-wk2π tv-simπ§ͺ api-gtk