[CG] Optimize getting the ImageFrame metadata #28799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash d8c4323) |
webkit-ews-buildbot
added
the
merging-blocked
shallawa
removed
the
merging-blocked
shallawa
force-pushed
the
eng/CG-Optimize-getting-the-ImageFrame-metadata
branch
from
d8c4323
to
9fef97e
Compare
|
EWS run on previous version of this PR (hash 9fef97e) |
webkit-ews-buildbot
added
the
merging-blocked
smfr
approved these changes
May 21, 2024
| @@ -147,4 +152,21 @@ bool ImageDecoder::supportsMediaType(MediaType type) | |||
| return false; | |||
| } | |||
|
|
|||
| bool ImageDecoder::frameMetadataAtIndex(size_t index, SubsamplingLevel subsamplingLevel, const DecodingOptions& options, ImageFrame& frame) const | |||
There was a problem hiding this comment.
The name is a bit vague. From the call site it's hard to see that this is filling some members of frame. Maybe fetchFrameMetaDataAtIndex()?
shallawa
removed
the
merging-blocked
shallawa
force-pushed
the
eng/CG-Optimize-getting-the-ImageFrame-metadata
branch
from
9fef97e
to
dfb0a0d
Compare
|
EWS run on current version of this PR (hash dfb0a0d) |
https://bugs.webkit.org/show_bug.cgi?id=274399 rdar://126232516 Reviewed by Simon Fraser. BitmapImageSource::cacheMetadataAtIndex() currently makes separate calls to ImageDecoder functions. Some of them calls CGImageSourceCopyPropertiesAtIndex() and we end up calling CGImageSourceCopyPropertiesAtIndex() multiple times. This can be optimized by adding ImageDecoder::frameMetadataAtIndex() which fills in the ImageFrame metadata. This way CGImageSourceCopyPropertiesAtIndex() will be called once and its CFDictionary will be used to retrieve all the ImageFrame metadata. * Source/WebCore/platform/graphics/BitmapImageSource.cpp: (WebCore::BitmapImageSource::cacheMetadataAtIndex): * Source/WebCore/platform/graphics/ImageDecoder.cpp: (WebCore::ImageDecoder::fetchFrameMetaDataAtIndex const): * Source/WebCore/platform/graphics/ImageDecoder.h: (WebCore::ImageDecoder::frameDensityCorrectedSizeAtIndex const): (WebCore::ImageDecoder::densityCorrectedSizeAtIndex const): Deleted. * Source/WebCore/platform/graphics/ImageFrame.h: * Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp: (WebCore::frameSizeFromProperties): (WebCore::ImageDecoderCG::encodedDataStatus const): (WebCore::ImageDecoderCG::hasAlpha const): (WebCore::ImageDecoderCG::frameSizeAtIndex const): (WebCore::ImageDecoderCG::frameOrientationAtIndex const): (WebCore::ImageDecoderCG::frameDensityCorrectedSizeAtIndex const): (WebCore::ImageDecoderCG::frameHasAlphaAtIndex const): (WebCore::ImageDecoderCG::fetchFrameMetaDataAtIndex const): (WebCore::ImageDecoderCG::decodeUTI): (WebCore::ImageDecoderCG::shouldUseQuickLookForFullscreen const): (WebCore::ImageDecoderCG::densityCorrectedSizeAtIndex const): Deleted. * Source/WebCore/platform/graphics/cg/ImageDecoderCG.h: * Source/WebCore/platform/image-decoders/ScalableImageDecoder.h: Canonical link: https://commits.webkit.org/279069@main
webkit-commit-queue
force-pushed
the
eng/CG-Optimize-getting-the-ImageFrame-metadata
branch
from
dfb0a0d
to
828ba37
Compare
|
Committed 279069@main (828ba37): https://commits.webkit.org/279069@main Reviewed commits have been landed. Closing PR #28799 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
828ba37
dfb0a0d
🧪 wpe-wk2🧪 ios-wk2🧪 ios-wk2-wpt🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🧪 api-gtk🛠 watch